Add SHA-256 for layer.zip file in SDK and Lambda Layer Release Workflows #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyuan-he
changed the title
yiyuan-he
changed the title
yiyuan-he
force-pushed
the
add-layer-sha256
branch
from
16b1012 to
7c5b4cc
Compare
This was referenced Mar 10, 2025
wangzlei
approved these changes
Mar 10, 2025
yiyuan-he
added a commit
to aws-observability/aws-otel-js-instrumentation
that referenced
this pull request
Mar 10, 2025
…cts (#165) *Description of changes:* Same as: aws-observability/aws-otel-python-instrumentation#335 and aws-observability/aws-otel-python-instrumentation#337 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
yiyuan-he
added a commit
to aws-observability/aws-otel-java-instrumentation
that referenced
this pull request
Mar 10, 2025
…cts (#1038) *Description of changes:* Same as: aws-observability/aws-otel-python-instrumentation#335 and aws-observability/aws-otel-python-instrumentation#337 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
ezhang6811
pushed a commit
to aws-observability/aws-otel-js-instrumentation
that referenced
this pull request
Mar 10, 2025
…cts (#165) *Description of changes:* Same as: aws-observability/aws-otel-python-instrumentation#335 and aws-observability/aws-otel-python-instrumentation#337 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
XinRanZhAWS
pushed a commit
to aws-observability/aws-otel-java-instrumentation
that referenced
this pull request
Mar 11, 2025
…cts (#1038) *Description of changes:* Same as: aws-observability/aws-otel-python-instrumentation#335 and aws-observability/aws-otel-python-instrumentation#337 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
yiyuan-he
added a commit
to yiyuan-he/aws-otel-python-instrumentation
that referenced
this pull request
Mar 11, 2025
…ows (aws-observability#337) *Issue #, if available:* We require SHA-256 file for every artifact that we vend. Otherwise, our canaries will not be able to download the artifact and we will receive availability drop alarms. *Description of changes:* Add logic to generate and upload a SHA-256 file for `layer.zip` file in our lambda layer and sdk release workflows. **Test plan:** Tested `gh` commands in workflow steps work on release notes copy in forked repo. https://github.com/yiyuan-he/aws-otel-java-instrumentation/releases/tag/v2.0.0 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
We require SHA-256 file for every artifact that we vend. Otherwise, our canaries will not be able to download the artifact and we will receive availability drop alarms.
Description of changes:
Add logic to generate and upload a SHA-256 file for
layer.zipfile in our lambda layer and sdk release workflows.Test plan:
Tested
ghcommands in workflow steps work on release notes copy in forked repo.https://github.com/yiyuan-he/aws-otel-java-instrumentation/releases/tag/v2.0.0
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.